search

Jumoo / uSyncMigrations

Rough and ready migration code.
Mozilla Public License 2.0
44 stars 57 forks source link

multiple grid configurations causes duplicate keys #255

Closed UmbracoReynolds closed 4 months ago

UmbracoReynolds commented 8 months ago

Describe the bug having multiple layout configurations for a gridlayout (see screenshot 1) causes duplicate keys in the config files after migrating.

here is an example of the config files (see screenshot 2). Each area of the blockgrids is assigned nonrandom keys so they clash when you have multiple sections: (see screenshot 2)

To Reproduce Steps to reproduce the behavior:

  1. Go to 'grid Data Type'
  2. Click on 'Add Grid Layout'
  3. Migrate
  4. See error for duplicate keys

Expected behavior I may be mistaken but I feel like this should not create duplicate keys, if multiple grid layouts like that are not valid input then the error should be custom to explain that to the user. currently the user gets a confusing duplicate key error.

Screenshots screenshot 1: image screenshot 2: image

About your Site (please complete the following information):

UmbracoReynolds commented 8 months ago

We fixed this by just removing the configurations since we didn't really use them in the site but for other websites this could be a larger problem so I thought I would mention it here