search

Jumoo / uSyncMigrations

Rough and ready migration code.
Mozilla Public License 2.0
44 stars 57 forks source link

Setting default version to both 7 and 8 #261

Open CodingDK opened 6 months ago

CodingDK commented 6 months ago

I changed the "default" version to support both 7 and 8. Because the version is set to 7 - most of the converteres are not used.

I am aware that this may not be the desired logic - alternatively, the version must be set on all migrators that are desired for 7 or 8.

KevinJump commented 4 months ago

yeah - not sure - doing some other refactoring so i will check this one. in theory should be fine,

CodingDK commented 4 months ago

You should not merge it into main yet. I used the changes on a work project earlier this week. It removes config values and converts incorrectly on¨some properties during an umbraco 8 migration (eg mediapicker -> mediaPicker3) - because these migrators only handle "prevalues" and not config.

KevinJump commented 4 months ago

Yes, increasingly i am thinking there are two categories of migration,

a) hard v7 ones, b) less hard v8 ones. :)

I am sort of aiming for splitting thigns a little bit, so in theory we can have the 'less hard' v8 stuff happen in a way that means we can us it in uSync proper