Jumoo / uSyncMigrations

Rough and ready migration code.
Mozilla Public License 2.0
44 stars 58 forks source link

Media properties are not included in the migration #92

Open sebastiandammark opened 1 year ago

sebastiandammark commented 1 year ago

I tried to make an upgrade from 8.11.1 to 11.2.1

From left to right, the properties title and photographer are missing after the migration. The crops defined on the Image Cropper was missing as well.

image
KevinJump commented 1 year ago

You don't actually need to run a migration from V8 to v11. As the files are actually the same.

You can copy usync/v8 files into a uSync/v9 (or rename the folder from v8 to v9 folder and run the import

Migrations are only required when coming from v7.

We have conversions for V8 but they are for changing things like nested content to block lists.

ProNotion commented 1 year ago

I think I possibly am seeing the same coming from v7. It picked up a custom media type we had in the site but did not include migrations files for any of the core media types which had customisations such as new/additional properties that are not included in the Core.

ProNotion commented 1 year ago

@sebastiandammark Probably too late for you now but I started a discussion relating to this and what I think are the reasons why.

AllanMT commented 11 months ago

Hi, I used your very-useful uSync.Migrations/4.0.0-phase.3 to try migrating an Umbraco 7.15.10 site uSync export to 10.5.1. One issue we had was that an alttext property we had created on images, and two properties title and description that we had created for files (so that a parent page could display the titles and descriptions of the files in a document collection on the page) were in the v7 uSync export but not migrated in to 10. I wasn't sure if this was the sort of thing you'd want to add in to uSyncMigrations , or whether we should be adding something to do this (and if so, where we'd find out how)?

danbramall commented 2 weeks ago

I'm experiencing this issue on a migration with many thousands of media items and lots of custom properties, so it's looking like a showstopper at the moment 😰. How have people overcome it?

AllanMT commented 2 weeks ago

Hi @danbramall , at first I went into the Umbraco 10, used the backoffice to create the fields we needed e.g. Alt Text on our image media type, or Title and Description on our File media type, and then I wrote some SQL to fill the property data of these properties in the U10 database from the U7 database (both databases needed to be on the same SQL instance). I then discovered an easier method: I used uSync Migrations to first import "Settings", then went into the backoffice to create the fields we needed e.g. Alt Text on our image media type, or Title and Description on our File media type, and then used uSync Migrations to import Content/Media and the images and files came into U10 with the altText, title and description properties filled too.

AllanMT commented 2 weeks ago

I'd posted the SQL at https://github.com/Jumoo/uSyncMigrations/discussions/161 but the newer 2nd method seems better

danbramall commented 1 week ago

Thanks @AllanMT. So to clarify, you effectively just created the missing properties on the media types manually on the target environment (ensuring that the data types are completely correct and the property aliases were identical etc) and that was enough to enable the media import to recognise the properties so all of the data held against the media items was imported?

ProNotion commented 1 week ago

@danbramall Did you see my comments on the issue I linked above? The easiest way I found to deal with this is to clone the project and in uSync.Migrations.Core\Services\SyncMigrationService.cs I simply commented out the line context.AddBlocked(nameof(MediaType), UmbConstants.Conventions.MediaTypes.Image) and include the custom build in your project where you are running the migrations.

danbramall commented 1 week ago

@ProNotion I did see the comment, but had dismissed commenting out those blocked types as I'd assumed it would do 'bad things'. (I wonder why they're blocked by default?) Thanks for clarifying; I'll give it a whirl :)

ProNotion commented 1 week ago

@danbramall I've been running this for the last 12 months or more and have not discovered any issues caused by it. The other code I comment out relates to media properties so the property data is also updated without the media files needing to be present.

See this issue