search

Jumper251 / AdvancedReplay

Minecraft plugin to record players on your server
GNU General Public License v3.0
146 stars 59 forks source link

Replay issue on 1.17+ clients through 1.8 server(viaversion) #93

Open MrF1yn opened 2 years ago

MrF1yn commented 2 years ago

On playing a replay on a 1.8server from a 1.18-1.17 client the player npc doesnt spawn, block actions are still visible. This issue disappears on playing the replay from a 1.16.5 client which means that something has changed related to npc spawn packets in 1.18-1.17.

Would really be glad if this issue is fixed since a lot of minigames servers run 1.8 server forks along with viaversion for increased performance.

MrF1yn commented 2 years ago

Update: i watched the replay from another account and it worked! When I joined from both account and watched again it failed with the duplicate uuid warning which makes sense now that the client is ignoring duplicate packets

MrF1yn commented 2 years ago

Which basically means that instead of using the actual uuid,eid of the original player it needs to be replaced with a counterfiet for the client to render it.

Jumper251 commented 2 years ago

Maybe a config option that when enabled always uses the 1.18 way of spawning npcs could fix this.

MrF1yn commented 2 years ago

Or maybe directly integrate into viaversion and check the client's version then do the spawning according to it. A more handsfree experience

MrF1yn commented 2 years ago

Made a pull request addressing the issues