JunCheng98 / pe

0 stars 0 forks source link

UML diagram for UI component is complicated #11

Open JunCheng98 opened 3 years ago

JunCheng98 commented 3 years ago

The UML diagram drawn in the UI component is too complicated with a lot of components involved. The arrows drawn are also messy making it difficult to discern the direction.

image.png

nus-se-bot commented 3 years ago

Team's Response

The placement of the various classes is already as neat as it can possibly be in PlantUML. In fact, a lot of effort went into making the diagram as neat as possible through the addition of hidden links in PlantUML. It is also not possible to omit any of the classes in this class diagram as that would result in the loss of crucial information; everything that is being displayed here is already at the highest level of abstraction, and is necessary to understand the UI component.

Maybe a better option would be to either split the diagram up into different parts or use powerpoint to make the diagram neater. Or both.

Splitting the diagram up into different parts is not an option because the class diagram is already at the highest level of abstraction, unless the tester is suggesting that they are okay with arrows being split across multiple diagrams. Using Powerpoint also does not solve this problem of there being many classes and makes it much harder to version control.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Not sure what the team's response is regarding the following quote, since I did not say this:

"Maybe a better option would be to either split the diagram up into different parts or use powerpoint to make the diagram neater. Or both."

On another note, I still think that this UML diagram drawing causes minor cosmetic flaws. Hence, while I agree that the severity should be lowered to very low, the issue should still not be rejected.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]