JunCheng98 / pe

0 stars 0 forks source link

Error message for date could be worded better #5

Open JunCheng98 opened 3 years ago

JunCheng98 commented 3 years ago

When entering 'add-expense' command for 29/02/2021, the error message is:

Dates should be a valid calendar date of the format dd/mm/yyyy, cannot be earlier than 01/01/1970, and cannot be later than the current date

Minor error, but maybe the message can be modified slightly so users can know that they entered a wrong leap year.

nus-se-bot commented 3 years ago

Team's Response

The error message specifies a "valid calendar date". The user guide (on page 10) defines a valid calendar date such that

Valid ranges for days and months are governed by the rules of the Gregorian Calendar.

So if a "wrong leap year" is entered, it violates the above rules. Hence there is no discrepancy between user guide and app behavior, and there is no bug here.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]