JunCheng98 / pe

0 stars 0 forks source link

Shortcut for bookmark commands should be added #8

Open JunCheng98 opened 3 years ago

JunCheng98 commented 3 years ago

Other than the 'add-bookmark-...' commands, the other bookmark commands such as delete and edit do not have shortcut versions. This could affect the speed and flow of the users who use the application, and confuse users since the shortcut implementation is not consistent for all bookmark commands. Suggest adding shortcut versions for bookmark commands that do not have them.

nus-se-bot commented 3 years ago

Team's Response

Creating shortcut versions of the other bookmark commands such as deleting and editing bookmark transactions is a valid suggestion. However I do not think that not having shortcuts for those commands will confuse the users as the user guide states the correct format of each command very clearly and does not allow for any room for ambiguity for the user on what commands can be used.

Furthermore this is consistent with the commands to delete and edit transactions. Deleting and editing of transactions do not have shortcuts while adding of transactions has shortcuts.

For example, adding of expenses can be executed with the shortcut adde while deleting of an expense is done by executing the delete command on the Expenses tab. This behaviour is consistent with the bookmark commands where adding of bookmark expenses can be executed with the shortcut addbe while deleting of a bookmark expense is done by executing the delete-bookmark command on the Expenses tab.

Hence this is why we decided to keep the command format for deleting and editing of bookmark transactions similar to deleting and editing of transactions.

Furthermore, we think that this bug is not in scope because even when you type in the shortcut versions of the other bookmark commands such as delete and edit, the application will show a error message saying that this shortcut is not supported yet. We have clearly stated the various formats a certain command can handle and if the user is unsure of the accepted formats, the user will be able to refer back to the user guide or type help to bring up the user guide within the application to check what the accepted formats are for the various commands. We definitely can implement this in the future but currently we do not think that this should be a bug within the scope of the features we have delivered for V1.4.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]