search

JunLongling / pe

0 stars 0 forks source link

Names do not accept "/" which is common in Indian names #6

Open JunLongling opened 2 weeks ago

JunLongling commented 2 weeks ago

It is common for Indian names to contain "s/o" or "d/o" which is not allowed as a name in the current implementation. I believe it is reasonable for clients to have names containing "/" and thus this should be allowed to be in the name

Example:

/v new n/ John s/o John p/98765432 em/johndoe@example.com d/2020-10-10

will give error

nus-pe-bot commented 2 weeks ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Disallows "s/o" As the Name of the Volunteer.

스크린샷 2024-11-15 오후 5.07.02.png

Description The VolunSync does not allow user from entering the "s/o" as the name of the volunteer which might cause inconvenience to certain users of this app.

Steps to Reproduce:

  1. Open the app
  2. List the volunteers by entering "list".
  3. Type the add command with the name including "s/o".
  4. See the error message.

Expected Behaviour: The system should add the volunteer in the list of volunteers.

Actual Behaviour: Gives a error message providing the reason why the command does not work.

Disallowing "s/o" in a person name because "/" is used as a command delimiter is a potential problem as input is expected to match the legal name of the person.

[original: nus-cs2103-AY2425S1/pe-interim#1430] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for raising this issue.

However, It's indicated in the UG that the inputs that the command only accepts Non-accented alphanumeric and spaces only, 1-100 characters.

image.png

Additionally, it is also not as important to implement compared to other more pressing features as it can be easily overcome by using SO and DO instead of the /.

Finally, the command fails gracefully, and has an error message to indicate that it would only accept alphanumeric characters and spaces, therefore it should be classified as NotInScope

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]