JunWei3112 / pe

0 stars 0 forks source link

Invalid email address is accepted when adding a contact #2

Open JunWei3112 opened 2 years ago

JunWei3112 commented 2 years ago

When adding a contact, it is stated that the domain name in the email address is made up of domain labels separated by periods. However, an email address with a domain name that has only 1 domain label can still be added.

Screenshot 2021-11-12 at 4.27.15 PM.png

In the screenshot above, the email address "example@hello" is accepted as a valid email address, although it should be invalid according to the error message. This may cause a minor inconvenience to users since they are able to add contacts with invalid email addresses.

nus-pe-bot commented 2 years ago

Team's Response

There was no mention in the User Guide that the "domain name in the email address is made up of domain labels separated by periods"

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: It is stated in the error message provided in the app. This can be seen in the error message provided in the screenshot. To replicate this error, you can type in this command add n/John r/client p/123 e/hello a/abc, and the statement The domain name is made up of domain labels separated by periods. can be seen in the error message.

Screenshot 2021-11-17 at 1.28.30 PM.png