search

JunWei3112 / pe

0 stars 0 forks source link

Editing the fields in the JSON data file to be null crashes the app #8

Open JunWei3112 opened 2 years ago

JunWei3112 commented 2 years ago

Screenshot 2021-11-12 at 5.05.39 PM.png

Screenshot 2021-11-12 at 5.06.34 PM.png

As seen in the screenshots, editing one of the fields in the data file to be null will cause the app to crash, and not start. While this might not happen to most users, some users may want to edit the JSON file like this and this may cause inconvenience for them.

nus-pe-bot commented 2 years ago

Team's Response

...some users may want to edit the JSON file like this ...

The term "like this" does not have a clear context, and the developers will assume the tester means that the users are trying to achieve something by putting a value of null.

To evaluate whether this should be accepted as a bug, we have to understand the purpose of the user entering null into the square brackets. The only explanation would be that tester wants to clear the schedules by directly editing the JSON file. This should not happen often, if at all, to the user.

If a user were to have the confidence to edit the JSON file directly, we can safely assume that they understand the significance of not abiding by the original format of the storage file, understand the square brackets in the file means an array and the significance of putting in a value of null within said square brackets.

The example provided is henceforth a form of intentional sabotage, and should therefore be rejected.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: In the explanation that the team provided, the team stated that This should not happen often, if at all, to the user and that we can safely assume that..., which are assumptions that the team holds. That means it is still possible for the user to put in a value of null in the JSON data file, like for when the user wants to clear up his or her schedules, without truly understanding the implications of null. They will then expect that the app will launch with their schedules being cleared up. However, the app does not start up at all, which is definitely a problem that the team should have handled, since now it renders the app unusable for the user. So, this should still be considered a bug.