Allow selecting Win32Legacy client in config

[gtbX]

This way you can access the in-game store while using wine

[JuneStepp]

The in-game store should work fine with the 64-bit client and I think the normal 32-bit one as well. Have you tried using OneLauncher's built in WINE setup?

[gtbX]

The in-game store should work fine with the 64-bit client and I think the normal 32-bit one as well. Have you tried using OneLauncher's built in WINE setup?

I haven't, just been using the stock setup from my distro. Does OneLauncher download its own version? All of the suggested workarounds I've seen point to using the 32-bit legacy client. I'll try this out later tonight.

[JuneStepp]

I haven't, just been using the stock setup from my distro. Does OneLauncher download its own version? All of the suggested workarounds I've seen point to using the 32-bit legacy client. I'll try this out later tonight.

OneLauncher does, but you should still have the dependencies from your distro's version. OneLauncher's WINE setup will be used by default or whenever the prefix is set to .OneLauncher/wine/prefix. When enabled it will also set up DXVK and ESYNC or FSYNC.

[gtbX]

So I tried using the downloaded version of wine instead of my already-installed instance and the in-game store worked just fine. Even better than the legacy option since it doesn't open a browser outside of the game. Kinda makes this pull request pointless now. Makes me wonder what's different about my distro's version of wine since it's actually newer. Probably no game patches applied.

I'll close this unless you think it may still be useful

[JuneStepp]

It would probably be worth it to have this feature in case someone does need access to the legacy client. I believe you could override it in some game config manually, but no one wants to do that. OneLauncher uses is a tkg patched version of wine-staging. I can't remember if it is that or DXVK that fixes the store.

[sourcery-ai[bot]]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.38%.

Quality metrics	Before	After	Change
Complexity	18.72 😞	18.09 🙂	-0.63 👍
Method Length	90.95 🙂	90.54 🙂	-0.41 👍
Working memory	16.40 ⛔	16.29 ⛔	-0.11 👍
Quality	42.87% 😞	43.25% 😞	0.38% 👍

Other metrics	Before	After	Change
Lines	2539	2546	7

Changed files	Quality Before	Quality After	Quality Change
OneLauncher/MainWindow.py	46.92% 😞	46.97% 😞	0.05% 👍
OneLauncher/OneLauncherUtils.py	40.43% 😞	41.03% 😞	0.60% 👍
OneLauncher/Settings.py	21.30% ⛔	22.60% ⛔	1.30% 👍
OneLauncher/SettingsWindow.py	60.32% 🙂	60.92% 🙂	0.60% 👍
OneLauncher/StartGame.py	41.95% 😞	41.94% 😞	-0.01% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
OneLauncher/Settings.py	Settings.LoadSettings	60 ⛔	426 ⛔	29 ⛔	3.82% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/OneLauncherUtils.py	WorldQueueConfig.__init__	46 ⛔	490 ⛔	31 ⛔	5.26% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/MainWindow.py	MainWindowThread.GetNews	33 ⛔	445 ⛔	22 ⛔	11.98% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/StartGame.py	StartGame.__init__	23 😞	497 ⛔	49 ⛔	13.95% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/MainWindow.py	MainWindow.AuthAccount	48 ⛔	394 ⛔	14 😞	14.73% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

[sourcery-ai[bot]]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.38%.

Quality metrics	Before	After	Change
Complexity	18.72 😞	18.09 🙂	-0.63 👍
Method Length	90.95 🙂	90.54 🙂	-0.41 👍
Working memory	16.40 ⛔	16.29 ⛔	-0.11 👍
Quality	42.87% 😞	43.25% 😞	0.38% 👍

Other metrics	Before	After	Change
Lines	2539	2546	7

Changed files	Quality Before	Quality After	Quality Change
OneLauncher/MainWindow.py	46.92% 😞	46.97% 😞	0.05% 👍
OneLauncher/OneLauncherUtils.py	40.43% 😞	41.03% 😞	0.60% 👍
OneLauncher/Settings.py	21.30% ⛔	22.60% ⛔	1.30% 👍
OneLauncher/SettingsWindow.py	60.32% 🙂	60.92% 🙂	0.60% 👍
OneLauncher/StartGame.py	41.95% 😞	41.94% 😞	-0.01% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
OneLauncher/Settings.py	Settings.LoadSettings	60 ⛔	426 ⛔	29 ⛔	3.82% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/OneLauncherUtils.py	WorldQueueConfig.__init__	46 ⛔	490 ⛔	31 ⛔	5.26% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/MainWindow.py	MainWindowThread.GetNews	33 ⛔	445 ⛔	22 ⛔	11.98% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/StartGame.py	StartGame.__init__	23 😞	497 ⛔	49 ⛔	13.95% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/MainWindow.py	MainWindow.AuthAccount	48 ⛔	394 ⛔	14 😞	14.73% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.