search

JuneStepp / OneLauncher

Launcher and Addons Manager for LOTRO and DDO
Other
45 stars 11 forks source link

Allow selecting Win32Legacy client in config (Sourcery refactored) #13

Closed sourcery-ai[bot] closed 3 years ago

sourcery-ai[bot] commented 3 years ago

Pull Request #12 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to the original Pull Request

    Incorporate changes via command line 
    git fetch https://github.com/JeremyStepp/OneLauncher pull/12/head
git merge --ff-only FETCH_HEAD
git push

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.45%.

Quality metrics Before After Change
Complexity 18.72 😞 17.64 🙂 -1.08 👍
Method Length 90.95 🙂 90.42 🙂 -0.53 👍
Working memory 16.40 ⛔ 16.28 ⛔ -0.12 👍
Quality 42.87% 😞 43.32% 😞 0.45% 👍
Other metrics Before After Change
Lines 2539 2539 0
Changed files Quality Before Quality After Quality Change
OneLauncher/MainWindow.py 46.92% 😞 46.97% 😞 0.05% 👍
OneLauncher/OneLauncherUtils.py 40.43% 😞 40.45% 😞 0.02% 👍
OneLauncher/Settings.py 21.30% ⛔ 23.85% ⛔ 2.55% 👍
OneLauncher/SettingsWindow.py 60.32% 🙂 60.92% 🙂 0.60% 👍
OneLauncher/StartGame.py 41.95% 😞 41.94% 😞 -0.01% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
OneLauncher/Settings.py Settings.LoadSettings 51 ⛔ 417 ⛔ 29 ⛔ 5.13% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/OneLauncherUtils.py WorldQueueConfig.__init__ 46 ⛔ 490 ⛔ 31 ⛔ 5.26% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/MainWindow.py MainWindowThread.GetNews 33 ⛔ 445 ⛔ 22 ⛔ 11.98% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/StartGame.py StartGame.__init__ 23 😞 497 ⛔ 49 ⛔ 13.95% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/MainWindow.py MainWindow.AuthAccount 48 ⛔ 394 ⛔ 14 😞 14.73% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.