search

JuneStepp / OneLauncher

Launcher and Addons Manager for LOTRO and DDO
Other
45 stars 11 forks source link

Downgrade SSL cipher level for game servers #22

Closed gtbX closed 3 years ago

gtbX commented 3 years ago

I recently started seeing SSL errors when trying to launch a game. This is what I got in the terminal output:

MainWindow - WARNING - <urlopen error [SSL: DH_KEY_TOO_SMALL] dh key too small (_ssl.c:1145)>
MainWindow - ERROR - [E12] Error getting news
MainWindow - ERROR - [E15] SSL Error occurred in HTTPS connection

Using openssl 1.1.1k and python3.9, not sure which one introduced the issue. According to https://askubuntu.com/a/1263098, the default security level was increased to 2; this patch sets it back down to 1 for the news and game queue connections.

Ideally, Standing Stone should update their servers, but I'm not holding my breath.

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.17%.

Quality metrics Before After Change
Complexity 14.72 🙂 14.67 🙂 -0.05 👍
Method Length 92.14 🙂 92.43 🙂 0.29 👎
Working memory 11.28 😞 11.39 😞 0.11 👎
Quality 51.07% 🙂 50.90% 🙂 -0.17% 👎
Other metrics Before After Change
Lines 1763 1768 5
Changed files Quality Before Quality After Quality Change
OneLauncher/MainWindow.py 56.34% 🙂 55.99% 🙂 -0.35% 👎
OneLauncher/OneLauncherUtils.py 41.26% 😞 41.46% 😞 0.20% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
OneLauncher/OneLauncherUtils.py WorldQueueConfig.__init__ 46 ⛔ 490 ⛔ 29 ⛔ 5.54% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/MainWindow.py MainWindow.AuthAccount 48 ⛔ 394 ⛔ 12 😞 17.72% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/OneLauncherUtils.py AuthenticateUser.__init__ 28 😞 279 ⛔ 18 ⛔ 20.26% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/MainWindow.py MainWindowThread.GetNews 25 😞 300 ⛔ 16 ⛔ 23.04% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
OneLauncher/MainWindow.py MainWindow.InitialSetup 26 😞 748 ⛔ 11 😞 26.12% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!