search

JuneStepp / OneLauncher

Launcher and Addons Manager for LOTRO and DDO
Other
45 stars 11 forks source link

setuptools missing from runtime dependencies #50

Closed mcbeth closed 5 months ago

mcbeth commented 5 months ago

It looks like setuptools is missing from the runtime dependencies. If I run the tool without it, after the wizard, the app fails to start when it tries to import pkg_resources. Once I do add setuptools to the dependency list, I get the expected network failure (this was written during the great easter network outage)

JuneStepp commented 5 months ago

Thanks! Fixed in e68ddb2e459b18d7d9148971e93cd49774b1f9d9. Setuptools is no longer needed.

mcbeth commented 5 months ago

I can confirm that setuptools is no longer needed, but you do technically need packaging now

JuneStepp commented 5 months ago

packaging was already in use, but I've explicitly added it to the pyproject.toml now. For whatever reason, I thought it was part of the standard library.