search

JungDev / django-telegrambot

Simple app for Telegram bot in Django
BSD 3-Clause "New" or "Revised" License
237 stars 88 forks source link

Fix gunicorn WEBHOOK mode issue #10

Closed arthurbarros closed 4 years ago

arthurbarros commented 6 years ago

This PR will fix issue #6

codecov-io commented 6 years ago

Codecov Report

Merging #10 into master will decrease coverage by 0.1%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   31.39%   31.29%   -0.11%     
==========================================
  Files           8        8              
  Lines         293      294       +1     
==========================================
  Hits           92       92              
- Misses        201      202       +1
Impacted Files Coverage Δ
django_telegrambot/apps.py 35.86% <0%> (-0.2%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c824df3...6287254. Read the comment docs.

arthurbarros commented 6 years ago

@JungDev is this gonna be merged ? Want to update my requirements.txt to point back to the plain pip repo instead of my own fork

JungDev commented 6 years ago

Sorry, but this check in your code at L174 is incomplete: if not.get Webhook Info().url != hookurl: All others parameters may change !