search

JungDev / django-telegrambot

Simple app for Telegram bot in Django
BSD 3-Clause "New" or "Revised" License
237 stars 88 forks source link

Should fail if app cannot be initalized #13

Closed alephyud closed 6 years ago

alephyud commented 6 years ago

The app initializer catches all exceptions that happen during loading telegrambot modules in user apps, and only logs a debug message in case if import fails - until I looked at the source code, I had to spend more than an hour to understand what was happening.

I think this at least merits an error log message (ideally, the Django app shouldn't even start if there is an error during initialization, but that change may be backwards-incompatible).

Happy to submit a pull request if you agree.

JungDev commented 6 years ago

You are right and thanks for help. If you want submit a pull request I will integrate it.