search

JungDev / django-telegrambot

Simple app for Telegram bot in Django
BSD 3-Clause "New" or "Revised" License
237 stars 88 forks source link

Changes to use Django installed apps registry #2

Closed peleccom closed 7 years ago

peleccom commented 7 years ago

Django 1.7 introduced a new applications framework https://docs.djangoproject.com/en/1.7/ref/applications/. List of installed applications should be extracted using get_app_configs call.

Old coded didn't work with apps listed in new style like

INSTALLED_APPS = [
    'myapp.apps.MyAppConfig',
]
codecov-io commented 7 years ago

Codecov Report

Merging #2 into master will increase coverage by 1.01%. The diff coverage is 22.22%.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   22.22%   23.23%   +1.01%     
==========================================
  Files           7        7              
  Lines         135      142       +7     
==========================================
+ Hits           30       33       +3     
- Misses        105      109       +4
Impacted Files Coverage Δ
django_telegrambot/apps.py 29.7% <22.22%> (+0.97%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c25a9b...cc3fd53. Read the comment docs.

JungDev commented 7 years ago

Thank you very much for yours contribute