search

JungDev / django-telegrambot

Simple app for Telegram bot in Django
BSD 3-Clause "New" or "Revised" License
237 stars 88 forks source link

when update to python-telegram-bot v12? #29

Open alisher-matkurbanov opened 5 years ago

alisher-matkurbanov commented 5 years ago

Hello! Thanks for the project!

I want to ask are you going to update to python-telegram-bot v12 and when? Thank you!

lukruh commented 4 years ago

I've a django (2.2.6) setup with django-telegrambot (1.0.1) installed and it actually works with ptb v12. I think this is because of the downwards compability of ptb. One of the main (and probably most wanted) features of ptb12 is the context based approach. I just looked briefly into the django-telegrambot code, to see how and where the Updaters are created. If it's enough to change this part for example to Updater(.. use_context=True) or move the use_context option to the settings.py (DJANGO_TELEGRAMBOT), I could try to to that and create a PR. But If this requires more complex changes, I dont have the time to maintain this. However, it would be good to know if this project is still maintained. @JungDev ?

lukruh commented 4 years ago

I just created a new env and installed django3 ptb12 and only a small adjustment was neccessary, to get django_telegrambot to work with the new context. I created a PR. Also the way the urls are included could be changed to the new path(), which is used in newer django versions, but this still works as it is.. so I didn't touched it.

Here is the PR https://github.com/JungDev/django-telegrambot/pull/37

HosseyNJF commented 4 years ago

This PR should be merged... the old system is deprecated

lukruh commented 4 years ago

There is already a new version of ptb released and no of the PR has been merged yet. However, I have forked the repository and will try to merge any open PR in the future. It worked for me with Django 2.x and Django 3.x with python-telegram-bot v1.12+. Feel free to try it and create PR. You can install it with pip using the git url instead of the package name (see README.md): https://github.com/telebotter/django-telegrambot