search

Jungle-Bus / transport_mapcss

A set of uncompromising validation rules about public transport in JOSM
GNU General Public License v3.0
6 stars 4 forks source link

i18n #12

Closed frodrigo closed 6 years ago

frodrigo commented 6 years ago

Not to be merged. Work in progress. This branch is the a base for further work for Osmose-QA.

frodrigo commented 6 years ago

Thank you. Fixed.

frodrigo commented 6 years ago

Reintroduce French in po file

frodrigo commented 6 years ago

Got the process to build the required zip for JOSM.

@nlehuby I let you ask for the support of it into JOSM. For the support in Osmose I will directly use the po file.

nlehuby commented 6 years ago

Thanks a lot for that !

nlehuby commented 6 years ago

According to Dirk, the mapcss should be in the root directory, not in the data.

And we need to find a way to publish the built zip too, with a stable url.

Maybe an automated github release script can do the trick, but I'm not sure about the stable url.

frodrigo commented 6 years ago

Ok, I simplified the process to build the zip file.

I think we can simply commit the zip file.

frodrigo commented 6 years ago

I add the zip file to git to be available at download.

frodrigo commented 6 years ago

Rebase this PR on my new "dev" branch. This branch is now the base of my branch "osmose" https://github.com/frodrigo/transport_mapcss/tree/osmose. I already use my branch "osmose" to update into Omose the "transport" analyser. @nlehuby In Osmose I removed the two analyser in python you made and replaced it by code generated from the last mapcss of by my branch "osmose": https://github.com/frodrigo/osmose-backend/commit/188f8e4a8a0599fb3e39d4f3ae1becb440f9f69e

frodrigo commented 6 years ago

Ok. All done.

About Osmose: I delete python source code and move the item/class to the MapCSS generated code: https://github.com/frodrigo/osmose-backend/commit/188f8e4a8a0599fb3e39d4f3ae1becb440f9f69e#diff-511dd9d4ccd47d56b87c9b5ce8c32803L15

frodrigo commented 6 years ago

I moved the already done translation from Osmose Pyhton code analyser here. To help on translating this project we add an entry for it in Osmose Transifex: https://www.transifex.com/openstreetmap-france/osmose/transport_mapcss/

frodrigo commented 6 years ago

OK for me as it is. Github zip download not fit the need.

nlehuby commented 6 years ago

Hum, there is something wrong, there is no data folder in the zip anymore :thinking:

frodrigo commented 6 years ago

I removed because you tell me to do it, I probably misunderstood. Which is the right layout ?

nlehuby commented 6 years ago

I don't know ... let's return to what works:

There is also a regression, all the items within a group do not show up anymore ...

Do you use the group feature in Osmose ? I think it would make more sense to group all the checks from this file inside a "Public Transport" group. It would be easier to find them among other errors, and that was the reason why they were prefixed by "Jungle" in the last release.