search

Jungle-Bus / transport_mapcss

A set of uncompromising validation rules about public transport in JOSM
GNU General Public License v3.0
6 stars 4 forks source link

Update translation strings #32

Closed nlehuby closed 5 years ago

nlehuby commented 5 years ago

@frodrigo can you please review the translations files, upload them to transifex and tell me if you want me to work on some automatic update for transifex (see #25 )?

frodrigo commented 5 years ago

Do you fetch from transifex before ?

frodrigo commented 5 years ago

I'm not sure about removing the lines number is a good practice.

nlehuby commented 5 years ago

You are right, I forgot to pull the translations first! This is now done.

frodrigo commented 5 years ago

Now it is ok for me.

nlehuby commented 5 years ago

About the line numbers: I don't know what they are useful for, and they produce ugly diffs as the line numbers keep changing on each commit. But I can put them back if you prefer.

frodrigo commented 5 years ago

let's try to remove

nlehuby commented 5 years ago

If it's ok for you @frodrigo can you please upload the new po to transifex (I don't have the permissions to do so) and maybe to Osmose too ?

frodrigo commented 5 years ago

I was waiting for this to be merged

frodrigo commented 5 years ago

Push to transifex done.

frodrigo commented 5 years ago

Note, on fetch again from transifex line numbers are back.

nlehuby commented 5 years ago

And the encoding notices are removed again ... This is quite annoying!

How do you update the po files ?

frodrigo commented 5 years ago

I do not remember, probably with the make file. I think charset in the files are not required.

nlehuby commented 5 years ago

I don't think so: the msgmerge failed if it's not defined. It was the issue you noticed with the fa.po and cs.po file.

And how do you upload them to transifex ? With the CLI or via the website ?

frodrigo commented 5 years ago
nlehuby commented 5 years ago

pff, why is i18n always such a pain in the ass 🤯