JunhaoWang / bittrade

Project Site
https://junhaowang.github.io/bittrade/
MIT License
2 stars 1 forks source link

Question about the format #13

Open dongxulee opened 6 years ago

dongxulee commented 6 years ago

Instead of working on the Jupyter notebook, we work on .py file, so I don't quit understand what kind of format are you exactly looking for, by looking at the modification you made on my code, I just get the general idea. So is there sample files for the format of function, document, test function, protocol for the naming of the function? And can you tell me what is the problem why I can't pass the Travis test? I know part of the reason is the format, and then I find some compiling error. And also about the repo, I think I have trouble understanding every part of it, do I need to know everything to get started, or I just need to know part of it? And what is the most urgent task for now?

JunhaoWang commented 6 years ago
  1. the general idea I have is to have a python package that can be installed by anyone using simple "pip install ...", and this package is able to get data, train agent, and simulate trading with real or fake data

  2. it is fine to play with jupyter notebooks but I never had good experience developing a long-term project with it, since it is essentially a prototyping tool. also it is fine to experiment algorithm with jupyter notebook but commit new ideas to testable code in a package setting.

  3. it is impossible and unnecessary to know everything about the repo since our code that matters lives only in src/bittrade and tests/ and those are the only two repos you need to worry about, I ll take care of the rest

  4. the most urgent task is literature and project review and see what is done already by people. feel free to use this google doc to track progress.

  5. I will write utility functions on the side, such as calculating stats from data you retrieved.

dongxulee commented 6 years ago

How about the format and why I could not pass the test of Travis? What is Travis testing besides the format?