JunioJsv / minimum-flutter

Minimum, android app launcher written with Flutter.
MIT License
30 stars 1 forks source link

Icon pack support #2

Open Donnnno opened 3 months ago

Donnnno commented 3 months ago

As the title says! Support for icon packs like other launchers :)

Just stumbled on your launcher through F-Droid, and it has lots of potential.

A few things that are nice to haves:

Nova & Kvaesitso launcher both have good documentation for these things:

https://github.com/teslacoil/Example_NovaTheme/blob/master/DynamicCalendarIconAPI.md

https://kvaesitso.mm20.de/docs/developer-guide/integrations/icon-packs.html

PS. I'm an icon pack developer myself, so I'm a bit biased when it comes to this stuff ;)

JunioJsv commented 3 months ago

Great suggestions, I was already researching how I could implement support for icon packs

JunioJsv commented 3 months ago

In terms of material you, you are referring to those monochromatic icons, right?

Donnnno commented 3 months ago

Oh great! Material You are the monochromatic icons, yea.

There are many icon packs that utilize this feature:

https://help.niagaralauncher.app/article/150-list-of-android-material-you-icon-packs

However do some launchers lack the support, unfortunately.

https://docs.arcticons.com/faq/supported-launchers

JunioJsv commented 3 months ago

Hello, I just released a version with support for icon packs (com.gau.go.launcherex.theme, org.adw.launcher.THEMES). Since you mentioned that you are an icon pack developer, could you test it and send me feedback? The implementation is still basic, but I think it works with most packs.

Donnnno commented 3 months ago

Fantastic, I'll test it immediately :)

Donnnno commented 3 months ago

Super! It does work. In my quick tests I found the following issues however:

Screenshot_20240802_170008.png

Screenshot_20240802_170033.png

JunioJsv commented 3 months ago

I just uploaded a new version with the fix for the problem of not updating icons when switching from light to dark theme and vice versa.

JunioJsv commented 3 months ago

the other problem you reported, I will still investigate

Donnnno commented 3 months ago

The switching works like a charm now!

I'll investigate which apps have trouble with applying later.

And also while I'm at it, maybe an option to disable the drop shadow thingy might be nice too :-)

I'm adding Minimum to the supported launcher list with full support!

Donnnno commented 3 months ago

Update: it looks like those apps are system apps that are hidden by default on most launches. So it's not necessarily a launcher thing.

JunioJsv commented 3 months ago

Update: it looks like those apps are system apps that are hidden by default on most launches. So it's not necessarily a launcher thing.

I don't understand, what do you mean?

JunioJsv commented 3 months ago

Update: it looks like those apps are system apps that are hidden by default on most launches. So it's not necessarily a launcher thing.

I understand, it was actually displaying some system applications without the android.intent.category.LAUNCHER category, I will hide this type of application

JunioJsv commented 3 months ago

ready, in this version only applications with android.intent.category.LAUNCHER will be displayed

Donnnno commented 3 months ago

Nice! That fixed it :))

mondlicht-und-sterne commented 3 months ago

I am also an Icon Pack developer and would be delighted to receive it.

mondlicht-und-sterne commented 3 months ago

It works.

Mondstern Acrylic Icons.

IMG_20240803_160217_851

JunioJsv commented 2 months ago

Hello, I just posted a new version with the functionality to choose custom icons

Donnnno commented 2 months ago

Works great too!

mondlicht-und-sterne commented 2 months ago

For me, the latest version just loads and loads and loads.

Samsung S21 5G, Android 14 IMG_20240808_052719_763

JunioJsv commented 2 months ago

@mondlicht-und-sterne Have you tried clearing the app data? I'll need to collect the errors somehow to be able to resolve this.

JunioJsv commented 2 months ago

@mondlicht-und-sterne test with this new version