JuniorDjjr / SA-MixSets

https://www.mixmods.com.br/2019/08/mod-mixsets.html
MIT License
44 stars 6 forks source link

FireCoronaSize is using MediumGrassDistMult's setting #2

Closed dbozan99 closed 4 years ago

dbozan99 commented 4 years ago
if (ReadIniFloat(ini, &lg, "Graphics", "MediumGrassDistMult", &f)) {
    G_MediumGrassDistMult = f;
    WriteMemory<float*>(0x5DAD88 + 2, &G_MediumGrassDistMult, true);
}

if (ReadIniFloat(ini, &lg, "Graphics", "FireCoronaSize", &f)) {
    G_MediumGrassDistMult = f;
    WriteMemory<float*>(0x53B784 + 2, &G_MediumGrassDistMult, true);
}
dbozan99 commented 4 years ago

I was looking at the code again today when I realized that my title is wrong, the first G_MediumGrassDistMult goes out of scope (and even if it didn't it gets overwritten and never used again anyway), so FireCoronaSize is working as intended. It's just a typo.

JuniorDjjr commented 4 years ago

The problem is with MediumGrassDistMult, it overwrites it.

JuniorDjjr commented 4 years ago

Fixed.