Fix issues mentioned by VLC developers - Githubissues

Juniper / amt-vlc

Module for the VLC media player leveraging AMT functionality

6 stars 5 forks source link

Fix issues mentioned by VLC developers #7

Closed natzberg closed 5 years ago

natzberg commented 5 years ago

https://mailman.videolan.org/pipermail/vlc-devel/2018-November/121776.html VLC developers commented on some issues with the code. Mainly:

check that things were ACTUALLY allocated
"Also, you should be using strok_r() to ensure the buffer isn't clobbered by another thread."
when freeing mcastGroup, relayAddr, and srcAddr, dont need to check if NULL
use vlc_strerror in many cases instead of msg_error