Closed mamathac closed 1 year ago
chidanandpujar
commented
1 year ago @mamathac
Thanks ,
_check_type_dict looks to be deprecated according to following document
_check_type_dict() --> :func:ansible.module_utils.common.validation.check_type_dict
I will check and update .
Thanks & Regards Chidanand
chidanandpujar
commented
1 year ago Hi @mamathac Thanks, I have verified the fix and looks to be working fine and will create the pull request . for persistent connection , ansible side fix is required https://github.com/ansible/ansible/issues/79371 , which is not still merged by Ansible , we need to apply this fix and verify the playbook
~/ansible_release_v103/ansible-junos-stdlib/tests# ansible-playbook pb.juniper_junos_persistent_conn.yml -vvv
ansible-playbook [core 2.15.5]
config file = /root/ansible_release_v103/ansible-junos-stdlib/tests/ansible.cfg
configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /root/ansible_release_v103/venv/lib/python3.9/site-packages/ansible
ansible collection location = /root/ansible_release_v103/ansible-junos-stdlib/ansible_collections
executable location = /root/ansible_release_v103/venv/bin/ansible-playbook
python version = 3.9.6 (default, Oct 18 2021, 17:33:10) [GCC 7.5.0] (/root/ansible_release_v103/venv/bin/python)
jinja version = 3.1.2
libyaml = True
Using /root/ansible_release_v103/ansible-junos-stdlib/tests/ansible.cfg as config file
host_list declined parsing /root/ansible_release_v103/ansible-junos-stdlib/tests/inventory as it did not pass its verify_file() method
script declined parsing /root/ansible_release_v103/ansible-junos-stdlib/tests/inventory as it did not pass its verify_file() method
auto declined parsing /root/ansible_release_v103/ansible-junos-stdlib/tests/inventory as it did not pass its verify_file() method
Parsed /root/ansible_release_v103/ansible-junos-stdlib/tests/inventory inventory source with ini plugin
Skipping callback 'default', as we already have a stdout callback.
Skipping callback 'minimal', as we already have a stdout callback.
Skipping callback 'oneline', as we already have a stdout callback.
PLAYBOOK: pb.juniper_junos_persistent_conn.yml ****************************************************************************************************************************
1 plays in pb.juniper_junos_persistent_conn.yml
PLAY [Test juniper.device.rpc module] *************************************************************************************************************************************
TASK [Get Device Configuration for interface] *****************************************************************************************************************************
task path: /root/ansible_release_v103/ansible-junos-stdlib/tests/pb.juniper_junos_persistent_conn.yml:11
<10.53.102.143> ESTABLISH LOCAL CONNECTION FOR USER: root
<10.53.102.143> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /root/.ansible/tmp/ansible-local-13699drbw_0_9 `"&& mkdir "` echo /root/.ansible/tmp/ansible-local-13699drbw_0_9/ansible-tmp-1697541963.1307323-13704-90440027433119 `" && echo ansible-tmp-1697541963.1307323-13704-90440027433119="` echo /root/.ansible/tmp/ansible-local-13699drbw_0_9/ansible-tmp-1697541963.1307323-13704-90440027433119 `" ) && sleep 0'
Using module file /root/ansible_release_v103/ansible-junos-stdlib/ansible_collections/juniper/device/plugins/modules/rpc.py
<10.53.102.143> PUT /root/.ansible/tmp/ansible-local-13699drbw_0_9/tmp_7zmvbbr TO /root/.ansible/tmp/ansible-local-13699drbw_0_9/ansible-tmp-1697541963.1307323-13704-90440027433119/AnsiballZ_rpc.py
<10.53.102.143> EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-local-13699drbw_0_9/ansible-tmp-1697541963.1307323-13704-90440027433119/ /root/.ansible/tmp/ansible-local-13699drbw_0_9/ansible-tmp-1697541963.1307323-13704-90440027433119/AnsiballZ_rpc.py && sleep 0'
<10.53.102.143> EXEC /bin/sh -c '/root/ansible_release_v103/venv/bin/python /root/.ansible/tmp/ansible-local-13699drbw_0_9/ansible-tmp-1697541963.1307323-13704-90440027433119/AnsiballZ_rpc.py && sleep 0'
<10.53.102.143> EXEC /bin/sh -c 'rm -f -r /root/.ansible/tmp/ansible-local-13699drbw_0_9/ansible-tmp-1697541963.1307323-13704-90440027433119/ > /dev/null 2>&1 && sleep 0'
ok: [test] => {
"attrs": {
"format": "xml",
"name": "re0"
},
"changed": false,
"format": "xml",
"invocation": {
"module_args": {
"attempts": null,
"attr": "name=re0",
"attrs": "name=re0",
"baud": null,
"console": null,
"cs_passwd": null,
"cs_user": null,
"dest": null,
"dest_dir": null,
"filter": "<configuration><groups><name>re0</name></groups></configuration>",
"format": "xml",
"formats": [
"xml"
],
"host": "10.53.102.143",
"huge_tree": false,
"ignore_warning": null,
"kwargs": null,
"level": null,
"logdir": null,
"logfile": null,
"mode": null,
"passwd": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
"port": 22,
"return_output": true,
"rpc": "get-config",
"rpcs": [
"get-config"
],
"ssh_config": null,
"ssh_private_key_file": null,
"timeout": 10,
"user": "root"
}
},
"kwargs": null,
"msg": "The \"get-config\" RPC executed successfully.",
"parsed_output": {
"configuration": {
"groups": {
"interfaces": {
"interface": {
"name": "fxp0",
"unit": {
"family": {
"inet": {
"address": {
"name": "10.53.102.143/19"
}
}
},
"name": "0"
}
}
},
"name": "re0",
"system": {
"backup-router": {
"address": "10.53.127.254"
},
"host-name": "evoeventtestx"
}
}
}
},
"rpc": "get-config",
"stdout": "<configuration changed-seconds=\"1697452040\" changed-localtime=\"2023-10-16 03:27:20 PDT\">\n <groups>\n <name>re0</name>\n <system>\n <host-name>evoeventtestx</host-name>\n <backup-router>\n <address>10.53.127.254</address>\n </backup-router>\n </system>\n <interfaces>\n <interface>\n <name>fxp0</name>\n <unit>\n <name>0</name>\n <family>\n <inet>\n <address>\n <name>10.53.102.143/19</name>\n </address>\n </inet>\n </family>\n </unit>\n </interface>\n </interfaces>\n </groups>\n</configuration>\n",
"stdout_lines": [
"<configuration changed-seconds=\"1697452040\" changed-localtime=\"2023-10-16 03:27:20 PDT\">",
" <groups>",
" <name>re0</name>",
" <system>",
" <host-name>evoeventtestx</host-name>",
" <backup-router>",
" <address>10.53.127.254</address>",
" </backup-router>",
" </system>",
" <interfaces>",
" <interface>",
" <name>fxp0</name>",
" <unit>",
" <name>0</name>",
" <family>",
" <inet>",
" <address>",
" <name>10.53.102.143/19</name>",
" </address>",
" </inet>",
" </family>",
" </unit>",
" </interface>",
" </interfaces>",
" </groups>",
"</configuration>"
]
}
TASK [Check TEST 7] *******************************************************************************************************************************************************
task path: /root/ansible_release_v103/ansible-junos-stdlib/tests/pb.juniper_junos_persistent_conn.yml:21
ok: [test] => {
"changed": false,
"msg": "All assertions passed"
}
PLAY RECAP ****************************************************************************************************************************************************************
test : ok=2 changed=0 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0
Thanks
chidanandpujar
commented
1 year ago Fix is merged via https://github.com/Juniper/ansible-junos-stdlib/pull/632
juniper.device collection and Python libraries version
OS / Environment
NA
Summary
On running a playbook to filter an RPC with args , error occurs.
Steps to reproduce
Run the ansible playbook shown
Expected results
Actual results