search

Juniper / ansible-junos-stdlib

Junos modules for Ansible
Apache License 2.0
302 stars 156 forks source link

implement rpc timeout #641

Closed apurvaraghu closed 3 months ago

apurvaraghu commented 6 months ago

fix issue #607

n3wtype commented 4 months ago

I just investigated this issue. It seems that timeout behaviour of commit_confirmed got broken with this commit: https://github.com/Juniper/ansible-junos-stdlib/commit/0cdae0e4d0274c5826da5ba74dec0ecbf7c1e999 .

It introduced timeout param for commit_confirmed with default value of 30.

However, the only place where commit_configuration is called is https://github.com/Juniper/ansible-junos-stdlib/blob/9e39e0023f25ffa4e4d430d5905e60299018ad9a/ansible_collections/juniper/device/plugins/modules/config.py#L1229 and timeout parameter is not passed here, so default value is always used.

I think more proper solution would be to pass "timeout" parameter to this call if it was passed to module.