search

Juniper / apstra-go-sdk

Go SDK for Apstra
Apache License 2.0
3 stars 0 forks source link

code review #282

Closed chrismarget-j closed 2 months ago

chrismarget-j commented 2 months ago

Biggest change here is that I eliminated the global rawTelemetryServiceRegistryEntry object

The TestGetTelemetryServicesDeviceMapping() still needs some work. It seems to rely on pre-existing Apstra configurations.

Also, I have a question about this thing:

type TelemetryServiceMapping struct {
    ServiceName string   `json:"service_name"`
    Devices     []string `json:"devices"`
}

Should Devices here be []ObjectId? My Apstra doesn't have any values, so I can't tell what this is supposed to be.