LogicalDeviecPortRoleFlags was an ill-conceived idea to use a uint16 as a series of 16 bit flags.
It "worked", but was needlessly complicated.
This PR:
eliminates type LogicalDevicePortRoleFlags uint16
introduces type LogicalDevicePortRoles []enum.PortRole
removes the deprecated-by-apstra l3_server port role
adjusts various structs which previously used the "flags" type
rewrites much of apstra/api_design_interface_maps_integration_test.go .. I had to touch this file anyway, so converted it to use github.com/stretchr/testify/require helper functions
LogicalDeviecPortRoleFlagswas an ill-conceived idea to use a uint16 as a series of 16 bit flags.It "worked", but was needlessly complicated.
This PR:
type LogicalDevicePortRoleFlags uint16type LogicalDevicePortRoles []enum.PortRolel3_serverport roleapstra/api_design_interface_maps_integration_test.go.. I had to touch this file anyway, so converted it to usegithub.com/stretchr/testify/requirehelper functionsCloses #424 Closes #425 Closes #426