Code refactor

[hkumarmk]

• Code cleanup in node role Also updated agent contrailctl to write agent specific param to [AGENT] section
• code cleanup in contrail/baremetal_agent role
• code cleanup in contrail/common role
• code cleanup in high level playbooks
  • No need of multiple high level playbooks as they are not reducing the complexity in site.yml
  • No need of post_provision role as all it does is just reboot the node at this moment, just moved the code to site.yml
  • No need of var files and include_vars for baremetal_agent, as same ansible is running all code, so the variables ansible get are available to baremetal_agent role also. Also since baremetal_agent is using python script to setup agent, there are not lot of params it use, and they are available without this.

[hkumarmk]

@ramprackash @nitishkrishna this code is tested with agent container, but as I dont have a SM setup, I could not test it against baremetal agent, please test it and let me know if you see issues.

[ramprackash]

Tried running SM with this changes. Looks like the contrail_compute_mode=bare_metal that is set in the inventory loses its value in the node role and it tries to start agent container.

Also, global_config is not available in bare_metal role even though its defined in inventory.

[hkumarmk]

Lets sit tomorrow and see what is happening - it should not happen