search

Juniper / contrail-vrouter

Contrail Virtual Router
BSD 2-Clause "Simplified" License
217 stars 169 forks source link

Refactoring conditional directives for if wrappers. #87

Closed wmarquesr closed 8 years ago

wmarquesr commented 8 years ago

A suggestion to compile entire statements and expressions, as suggested by code style guidelines from the Linux Kernel and practitioners.

It might improve code understanding, maintainability and error-proneness.

pedro-r-marques commented 8 years ago

Please submit code via review.opencontrail.org. git-review should automatically pick up the correct URL.

wmarquesr commented 8 years ago

I'm sorry, but how i do this?

pedro-r-marques commented 8 years ago

install git-review

https://www.mediawiki.org/wiki/Gerrit/git-review

Gerrit/git-review - MediaWikihttps://www.mediawiki.org/wiki/Gerrit/git-review www.mediawiki.org git-review is a command-line tool for Git / Gerrit. It makes it easier to configure your Git clone, to submit a change or to fetch an existing one.

use the command "git review" to submit the code changes.

From: wmarquesr notifications@github.com Sent: Monday, December 14, 2015 11:59 AM To: Juniper/contrail-vrouter Cc: Pedro Marques Subject: Re: [contrail-vrouter] Refactoring conditional directives for if wrappers. (#87)

I'm sorry, but how i do this?

Reply to this email directly or view it on GitHubhttps://github.com/Juniper/contrail-vrouter/pull/87#issuecomment-164542581.

[https://avatars0.githubusercontent.com/u/7017961?v=3&s=400]https://github.com/Juniper/contrail-vrouter/pull/87#issuecomment-164542581

Refactoring conditional directives for if wrappers. by wmarquesr · Pull Request #87 · Juniper/contrail-vrouterhttps://github.com/Juniper/contrail-vrouter/pull/87#issuecomment-164542581 github.com A suggestion to compile entire statements and expressions, as suggested by code style guidelines from the Linux Kernel and practitioners. Linux kernel coding style Living in the #ifdef Hell It ...