Closed damianoneill closed 6 years ago
Done.
On 2 Jan 2018, at 15:13, Nachi Ueno notifications@github.com wrote: @nati commented on this pull request. Looks good but could you note that fpm is only needed you wanna make packages locally? In README.md https://github.com/Juniper/contrail/pull/33#discussion_r159244078: Apply lint tools Go get must simply work Follow best practices Effective Go: https://golang.org/doc/effective_go.html -# How to build +## Build pre-requistites + +The following software is required to build this project: + +- Install git +- Install go +- Install dep +- Install mysql +- Install fpm fpm is only needed for building packages. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Juniper/contrail/pull/33#pullrequestreview-86160143, or mute the thread https://github.com/notifications/unsubscribe-auth/AOtkcmrpV_bq5pvPa6YEAJfVrkN2Xh3Zks5tGkeKgaJpZM4RQr1d.
On 2 Jan 2018, at 15:13, Nachi Ueno notifications@github.com wrote:
@nati commented on this pull request.
Looks good but could you note that fpm is only needed you wanna make packages locally?
In README.md https://github.com/Juniper/contrail/pull/33#discussion_r159244078:
Apply lint tools Go get must simply work Follow best practices Effective Go: https://golang.org/doc/effective_go.html
-# How to build +## Build pre-requistites + +The following software is required to build this project: + +- Install git +- Install go +- Install dep +- Install mysql +- Install fpm fpm is only needed for building packages.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Juniper/contrail/pull/33#pullrequestreview-86160143, or mute the thread https://github.com/notifications/unsubscribe-auth/AOtkcmrpV_bq5pvPa6YEAJfVrkN2Xh3Zks5tGkeKgaJpZM4RQr1d.
Done.