search

Juniper / contrail

Contrail repo for core components (go based)
Apache License 2.0
44 stars 32 forks source link

Committing autogen code #34

Closed damianoneill closed 6 years ago

damianoneill commented 6 years ago

Why are we committing autogenerated code?

On the second step, ‘make generate’ this results in new files being generated in my workspace. These files have been committed to github.

If the intent is to supported a build generated solution as well as a checkout (and everything is there) solution, then the README.md should be updated to reflect this.

nati commented 6 years ago

because go get should work. kubernetes is doing same.

damianoneill commented 6 years ago

Ok, but then the doc should be rewritten into two sections, one for contributors and one for users. Each section would have a different set of commands based on the intended use. I think this should be done after the section headers / descriptions are done.

nati commented 6 years ago

yes. I agree. Could you raise new issue for that?

nati commented 6 years ago

could you close this one if you are ok?