Juniper / fluent-plugin-udp-native-sensors

Apache License 2.0
5 stars 10 forks source link

Optional fields #9

Open sjames-iberis opened 5 years ago

sjames-iberis commented 5 years ago

Hi @gaddevijay   Can you clarify whether the code at this point ever takes effect:? https://github.com/Juniper/fluent-plugin-udp-native-sensors/blob/1d781cf3a1dd8caee8056117d88e6f1caaca2647/juniper_telemetry_udp_lib.rb#L38

I'm a ruby novice but can the condition:

(not value.present? and value == 0)

ever be true?
The comment above the code suggests it should be

(not value.present? or value == 0)

Thanks, Simon