search

Juniper / go-netconf

NETCONF implementation in Go.
Other
253 stars 110 forks source link

fix hostkeycallback for other authentication methods #74

Closed darylturner closed 6 years ago

darylturner commented 6 years ago

Using the SSHConfig* convenience functions for SSH private key and SSH agent authentication results in a ssh: must specify HostKeyCallback error.

Added ssh.InsecureIgnoreHostKey to the ssh.ClientConfig structs so that they are inline with the SSHConfigPassword function (which was fixed in commit 418667039b1b346153765ff4b442e1bf42b2a9d5)

nemith commented 6 years ago

Defaulting to insecure for the user is a bad idea. 4186670 shouldn't have been committed either.

darylturner commented 6 years ago

@brbe I do agree with you there. It was more of a consistency fix. Can see you've proposed deprecating these functions in favor of letting the user decide which sounds sensible. Thanks.