search

Juniper / jtimon

Junos Telemetry Interface (JTI) client
Apache License 2.0
31 stars 10 forks source link

Need to be able to disable EOS for xpaths in preGNMI mode #38

Open xp600 opened 5 months ago

xp600 commented 5 months ago

With EOS enabled, subscriptions to xpaths in preGNMI mode cause Init Sync packets to be sent.

Google does not fetch initial sync data for preGNMI sensors.

To be consistent with the google collectors, we need the jtimon team to provide option to turn off init sync for pre-GNMI sessions.

@M-Vivek-Juniper , @amohit1315

amohit1315 commented 5 months ago

Hey @xp600 , do we need it enabled for GNMI and disable it for pre-GNMI, when EOS is explicitly configured in the jtimon configuration

xp600 commented 5 months ago

Hi @amohit1315, We need the flexibility to configure (enable/disable) EOS individually for preGNMI and GNMI xpaths please.

amohit1315 commented 4 months ago

Added config for enabling/disabling eos for internal jtimon configs. This configuration overrides the eos value set outside the internal-jtimon config section

Example:

"internal-jtimon": {
    "data-log-file": "TelemetrySensorData.log",
    "gnmi-eos": true,
    "pre-gnmi-eos": true
}

If not set within internal-jtimon, then this is set to false by default. Note: if EOS is enabled in main config and internal-jtimon is also configured, then eos will be set to default if eos is not configured in internal-jtimon

amohit1315 commented 4 months ago

Will move the ticket back, once the changes are approved and merged