search

Juniper / libxo

The libxo library allows an application to generate text, XML, JSON, and HTML output using a common set of function calls. The application decides at run time which output style should be produced.
http://juniper.github.io/libxo/libxo-manual.html
BSD 2-Clause "Simplified" License
325 stars 48 forks source link

portability fixes #82

Closed q66 closed 3 years ago

q66 commented 3 years ago

this allows for easier building on non-glibc systems (and glibc 2.32+, which dropped sysctl.h)

philshafer commented 3 years ago

Merged into 'develop' branch. Will roll a new release.

Thanks, Phil

q66 commented 3 years ago

i was also wondering if there's any good way to fix building with BSD Make - the only thing preventing it is https://github.com/Juniper/libxo/blob/master/warnings.mk, but it can't just easily be modified since the bmake syntax is different - i wonder if there's some way to do the same thing statically with autoconf/automake?

philshafer commented 3 years ago

While I prefer bmake, gmake is more widely available. I dislike libtool, but the same is true. They hopefully allow compilation on many diverse platforms at low cost.

When building under FreeBSD, I have “real” makefiles that “reach over” in /contrib/libxo/ to the latest import release of libxo. See https://github.com/freebsd/freebsd-src/tree/main/lib/libxo https://github.com/freebsd/freebsd-src/tree/main/lib/libxo

Thanks, Phil

On Jun 29, 2021, at 11:41 AM, Daniel Kolesa @.***> wrote:

i was also wondering if there's any good way to fix building with BSD Make - the only thing preventing it is https://github.com/Juniper/libxo/blob/master/warnings.mk https://github.com/Juniper/libxo/blob/master/warnings.mk, but it can't just easily be modified since the bmake syntax is different - i wonder if there's some way to do the same thing statically with autoconf/automake?

q66 commented 3 years ago

well, if we could fix warnings.mk somehow, we could have things build under both gmake and bmake (i have a patch in my system: https://github.com/chimera-linux/cports/blob/master/srcpkgs/libxo/patches/bmake.patch this is obviously not suitable for upstream though)

philshafer commented 3 years ago

Would it suffice to add 'make_cmd = “gmake”’ to your template.py file? cports list gmake as a dependency and other srcpkgs do this.

Thanks, Phil

On Jun 29, 2021, at 4:24 PM, Daniel Kolesa @.***> wrote:

well, if we could fix warnings.mk somehow, we could have things build under both gmake and bmake (i have a patch in my system: https://github.com/chimera-linux/cports/blob/master/srcpkgs/libxo/patches/bmake.patch https://github.com/chimera-linux/cports/blob/master/srcpkgs/libxo/patches/bmake.patch this is obviously not suitable for upstream though)

q66 commented 3 years ago

well, I plan to eliminate gmake from the base system eventually (it's there for now because I haven't figured out certain components yet)