search

Juniper / netconf-java

Java library for NETCONF
Other
76 stars 63 forks source link

Added command timeout #26

Closed Vladislav-Kisliy closed 4 years ago

Vladislav-Kisliy commented 4 years ago

improved a consuming performance, fixed an unit test, added device emulation to unit test

peterjhill commented 4 years ago

Any chance you can squash this into less commits?

Vladislav-Kisliy commented 4 years ago

Any chance you can squash this into less commits?

Vladislav-Kisliy commented 4 years ago

@peterjhill Actually I thought you can squash when you merge it but anyway I'll do it. Thanks for your comments, I'll change my PR and notify you

peterjhill commented 4 years ago

I can't merge it. :) maybe the juniper devs can. As a fellow user of this library, thanks for your contributions.

peterjhill commented 4 years ago

I think the only change I would want is to bump the version in the pom.xml from

2.0.1

to perhaps 2.1.0 ? with the new required arg in netconf session class, it could be a breaking change?

Vladislav-Kisliy commented 4 years ago

@peterjhill Hi. Please have a look. I returned old constructor, modified builder and squashed several commits. For the rest of them I'm not sure it's even possible without recreation my fork from the scratch

peterjhill commented 4 years ago

I pinged someone I know at Juniper about the PR. Hopefully they can take a look at it. THanks again Vlad!