search

Juniper / netconf-java

Java library for NETCONF
Other
76 stars 63 forks source link

Publish JAR to mvncentral? #31

Open senderic opened 4 years ago

senderic commented 4 years ago

Hi All, I am planning to use your Netconf API in my project and I was wondering if you'd consider publishing your JAR to mvncentral?

http://maven.apache.org/repository/guide-central-repository-upload.html https://central.sonatype.org/pages/requirements.html

I can help, however there are a few requirements, such as filling out a licence section in the POM and creating a javadoc/source jar file.

Appreciate all your hard work!

senderic commented 4 years ago

Added this commit to help towards this: https://github.com/Juniper/netconf-java/pull/30/commits/448c12e4a7d2ec0bfc7b247e02c5d058729e7c8f

And related PR: https://github.com/Juniper/netconf-java/pull/30

peterjhill commented 4 years ago

looks good. I definitely agree that having this published up to mvncentral would be great. Then I can stop publishing to our internal mvn.

senderic commented 4 years ago

looks good. I definitely agree that having this published up to mvncentral would be great. Then I can stop publishing to our internal mvn.

I agree, especially since the source code is on github anyway, might as well take the next step.

ydnath commented 4 years ago

Thanks Eric @esend7881

I have merged this. However, I am not aware of Maven publishing process. I will go through the documentation and get back.

senderic commented 4 years ago

Thanks Eric @esend7881

I have merged this. However, I am not aware of Maven publishing process. I will go through the documentation and get back.

FYI - I published your code to my companies nexus internal server, so I am good now. But yeah it would be great to have it on mvn central for others out there who'd want to use it (more easily).

peterjhill commented 3 years ago

github has this: https://docs.github.com/en/actions/guides/publishing-java-packages-with-maven That has info on how to use Sonatypes open source maven central artifact repository (to host the jar files).

This requires opening a jira account with sonatype: https://central.sonatype.org/publish/

This then give whomever sets this up permission to create releases. We then add some foo to the pom file and some github secrets for the account integration between github and sonatype. Details are all in there.

If you want to set up a sonatype account and add me as a person who can set up the integration I can do that. Not sure how busy you are. :)

senderic commented 3 years ago

@peterjhill I found some time and created this jira ticket https://issues.sonatype.org/browse/OSSRH-69987

Also I made a branch in my forked repo that has updates to the POM file https://github.com/esend7881/netconf-java/tree/RELEASE/2.1.1.4

We'll see what happens with the JIRA ticket at this point.

Update: The JIRA ticket has been updated with someone mentioning that net.juniper is already in use. They are wanting someone directly from your organization to approve it.

peterjhill commented 3 years ago

I pinged our friends at Juniper and asked them to comment in that jira ticket.

Thanks Erik!

GregDThomas commented 3 years ago

Hi folks - any chance of getting this looked at - would make things easier! Thanks.

ydnath commented 3 years ago

Let me review the process and get this done.

dkowis commented 3 years ago

I guess this got lost? It would still be nice to use maven central.

However, until then, you can use jitpack, if you're allowed to pull jar files from somewhere other than maven central:

https://jitpack.io/#Juniper/netconf-java