Juniper / open-nti

Open Network Telemetry Collector build with open source tools
Apache License 2.0
233 stars 93 forks source link

Anonymous access to grafana #166

Closed kzorba closed 7 years ago

kzorba commented 7 years ago

It seems convenient to me to be able to access grafana directly without user registration. In our deployment we have made the following adjustments in ./docker/grafana/custom.ini:

[users]

disable user signup / registration

-;allow_sign_up = true +allow_sign_up = false

[auth.anonymous]

enable anonymous access

-;enabled = false +enabled = true

Share your opinion on these, I think there is no need for a pull request.

3fr61n commented 7 years ago

I'm not sure about make this change the default one for grafana (but we could add it into the documentation)

However let's see what the opinion of the community about it

kzorba commented 7 years ago

Yes, not sure about making it the default in open-nti as well. I think perhaps this issue should be merged with #8 (persistent Grafana config). In our case the setup with anonymous access works best and we will keep it that way. I wouldn't like to keep a separate branch just for this though.

3fr61n commented 7 years ago

Hi Kostas,

Let's still wait for more comments from community

Meanwhile if you require to specify some config parameters that are not the default ones, you can always fork the repo, and put your default parameters in your repo, then for any future change we make in the openNTI repo you can always sync it

https://help.github.com/articles/syncing-a-fork/

Hope this could be a temporal workaround

Regards

On Tue, Jun 13, 2017 at 11:14 AM, Kostas Zorbadelos < notifications@github.com> wrote:

Yes, not sure about making it the default in open-nti as well. I think perhaps this issue should be merged with #8 https://github.com/Juniper/open-nti/issues/8 (persistent Grafana config). In our case the setup with anonymous access works best and we will keep it that way. I wouldn't like to keep a separate branch just for this though.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Juniper/open-nti/issues/166#issuecomment-308056554, or mute the thread https://github.com/notifications/unsubscribe-auth/AGZZNei5MRFxPl1VszbvTJq_-0WS3Pt7ks5sDlMHgaJpZM4N28Af .

-- Saludos Efrain Gonzalez

mwiget commented 7 years ago

Could the behaviour of granting anonymous access be controlled via environment variable at container launch?

3fr61n commented 7 years ago

Good Idea @mwiget,

Here is the ENV variables for grafana ( http://docs.grafana.org/installation/configuration/ )

@kzorba could you please test it, modifying your docker-compose file with [auth.anonymous]

kzorba commented 7 years ago

Sorry for the long delay in the answer. Tested it and it works like a charm. Thanks @mwiget! Created pull request #175 to have the options commented in docker-compose-persistent.yml for whoever is interested in this.