search

Juniper / py-junos-eznc

Python library for Junos automation
https://www.juniper.net/documentation/en_US/junos-pyez/information-products/pathway-pages/junos-pyez-developer-guide.html
Apache License 2.0
670 stars 344 forks source link

Do not disable SSH agent #1285

Open vincentbernat opened 11 months ago

vincentbernat commented 11 months ago

The current logic around the SSH agent is flawed and tentatives to fix it to cover more cases only leads to more complexity.

As seen in #648, to this day, nobody really knows why we disable the agent. In the meantime, many valid use cases just don't work because of disabling the agent, including the good practice to use encrypted private key files. I think it is time to bite the bullet and just leave the agent always on: "ssh" from OpenSSH does not have an option to disable the agent and nobody complains about this.

gaima8 commented 11 months ago

Can confirm this works. Better than my patches https://github.com/Juniper/py-junos-eznc/pull/1284 and https://github.com/Juniper/ansible-junos-stdlib/pull/634 as this only requires the one change here.