Juniper / py-junos-eznc

Python library for Junos automation
https://www.juniper.net/documentation/en_US/junos-pyez/information-products/pathway-pages/junos-pyez-developer-guide.html
Apache License 2.0
670 stars 344 forks source link

don't run `pip install` in `setup.py` #1318

Closed boegel closed 1 week ago

boegel commented 2 months ago

In the latest release of junos-eznc (2.7.1), the setup.py script includes a pip install command that is executed via os.system:

https://github.com/Juniper/py-junos-eznc/blob/2.7.1/setup.py#L6

This is quite nasty, as it can mess up people's Python environment very easily.

chidanandpujar commented 2 months ago

This change was introduced as part of #1299 https://github.com/Juniper/py-junos-eznc/pull/1299

dineshbaburam91 commented 1 week ago

Fixed #1342. Hence closed.