Fix checksum offload when TPG_SW_CHECKSUMMING is defined.

Juniper / warp17

The Stateful Traffic Generator for Layer 1 to Layer 7

BSD 3-Clause "New" or "Revised" License

424 stars 81 forks source link

Fix checksum offload when TPG_SW_CHECKSUMMING is defined. #118

Closed dceara closed 4 years ago

dceara commented 4 years ago

If software checksumming support is compiled in we still use hw checksumming when available but fall back to software when the NIC doesn't support the offload.

This enables hw offload whenever possible.

Signed-off-by: Dumitru Ceara dceara@redhat.com

dceara commented 4 years ago

@insanum this is the follow up fix I suggested here

dceara commented 4 years ago

code looks good to me, I can't compile/try it out until 9th of September (2020) though, if this is fine with you, I'll approve

@davvore33 Thanks! I tested it locally and it works fine, both with TPG_SW_CHECKSUMMING on and off. TravisCI also passes: https://travis-ci.org/github/Juniper/warp17/builds/719898698

I'd like to have this merged soon because without it dev/common is broken when TPG_SW_CHECKSUMMING=1.

Thanks, Dumitru