Junjue-Wang / LoveDA

[NeurIPS 2021] LoveDA: A Remote Sensing Land-Cover Dataset for Domain Adaptive Semantic Segmentation
361 stars 50 forks source link

The dict data type cann't be accessed by dot '.' #44

Open lauraset opened 2 years ago

lauraset commented 2 years ago

Hello, @Junjue-Wang. I want to know whether you have rewrited the dict data type. I can't accessed the members of dict by dot '.'. For example, for the SOURCE_DATA_CONFIG, when I try to obtain the value of 'image_dir', SOURCE_DATA_CONFIG['image_dir'] can work, but SOURCE_DATA_CONFIG.image_dir can not. image When you define LoveDALoader, the dot, e.g., config.batch_size can obtain the value of dict members. How to do it? Thank you in advance.

image

Junjue-Wang commented 2 years ago

Yes, we have re-implemented the dict for config

lauraset commented 2 years ago

@Junjue-Wang, Thank you very much. I still have one question about the clip_grad.clip_grad_norm_(filter(lambda p: p.requires_grad, model.parameters()), max_norm=35, norm_type=2). I guess the max_norm should be changed according to different datasets. Whether it is necessary for other new datasets? Thank you for your reply in advance.

Junjue-Wang commented 2 years ago
font{
    line-height: 1.6;
}
ul,ol{
    padding-left: 20px;
    list-style-position: inside;
}

    I think this is not sensitive to specific datasets

                ***@***.***

---- Replied Message ----

     From 

        ***@***.***>

     Date 

    8/25/2022 16:31

     To 

        ***@***.***>

     Cc 

        ***@***.***>
        ,

        ***@***.***>

     Subject 

          Re: [Junjue-Wang/LoveDA] The dict data type cann't be accessed by dot '.' (Issue #44)

@Junjue-Wang, Thank you very much. I still have one question about the clip_grad.clip_gradnorm(filter(lambda p: p.requires_grad, model.parameters()), max_norm=35, norm_type=2). I guess the max_norm should be changed according to different datasets. Whether it is necessary for other new datasets? Thank you for your reply in advance.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

lauraset commented 2 years ago

Oh, thank you anyway. I just want to know why max_norm is set to 35 . Do you set it by experiments?

Junjue-Wang commented 2 years ago
font{
    line-height: 1.6;
}
ul,ol{
    padding-left: 20px;
    list-style-position: inside;
}

    No, it is the default setting

                ***@***.***

---- Replied Message ----

     From 

        ***@***.***>

     Date 

    8/25/2022 17:13

     To 

        ***@***.***>

     Cc 

        ***@***.***>
        ,

        ***@***.***>

     Subject 

          Re: [Junjue-Wang/LoveDA] The dict data type cann't be accessed by dot '.' (Issue #44)

Oh, thank you anyway. I just want to know why max_norm is set to 35 . Do you set it by experiments?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

lauraset commented 2 years ago

Oh, I see. Thank you a lot.