JunkFood02 / Seal

🦭 Video/Audio Downloader for Android, based on yt-dlp, designed with Material You
GNU General Public License v3.0
11.1k stars 492 forks source link

[Feature Request] #102

Closed Marco-9456 closed 2 years ago

Marco-9456 commented 2 years ago

Is it possible to add the following;

  1. Mkv format
  2. Save and embed subtitles to the video.

I know that it's possible with a custom command but it would be great if these futures appear at the (configure before downloading) menu

JunkFood02 commented 2 years ago
  1. Maybe check this or something like Wikipedia. Also, the preferred video format is just for priority in sorting.
  2. I'll test it out if it's not so complicated
Marco-9456 commented 2 years ago
  1. Maybe check this or something like Wikipedia. Also, the preferred video format is just for priority in sorting.
  2. I'll test it out if it's not so complicated
  1. Thanks for the info.
  2. Good luck :)
JunkFood02 commented 2 years ago

Simply embedding the subtitle provided by the video can be done in one line. But, few people need auto-generated subtitles embedded into their videos I guess? 🤔

Marco-9456 commented 2 years ago

Simply embedding the subtitle provided by the video can be done in one line. But, few people need auto-generated subtitles embedded into their videos I guess? 🤔

That's good to hear,but I didn't mean auto-generated subtitles, i meant subtitles that are already provided for the video for example on Crunchyroll

Marco-9456 commented 2 years ago

Simply embedding the subtitle provided by the video can be done in one line. But, few people need auto-generated subtitles embedded into their videos I guess? 🤔

That's good to hear,but I didn't mean auto-generated subtitles, i meant subtitles that are already provided for the video for example on Crunchyroll

For Crunchyroll I used to use this command in Termux yt-dlp https://www.crunchyroll.com/de/jujutsu-kaisen/episode-1-ryomen-sukuna-797865 ---remux-video mkv --sub-lang arME --write-sub --convert-subs ass --embed-subs

JunkFood02 commented 2 years ago

--remux-video mkv is not needed because yt-dlp will automatically do this when the container does not support subtitle embedding. But for the language and the format, it'll be complicated if we provide these two options. So I'll do this by --sub-lang all and not adding --convert-subs.

Marco-9456 commented 2 years ago

--remux-video mkv is not needed because yt-dlp will automatically do this when the container does not support subtitle embedding. But for the language and the format, it'll be complicated if we provide these two options. So I'll do this by --sub-lang all and not add--remux-video mkving --convert-subs.

Screenshot_20220807-155621_Termux

Screenshot_20220807-155803_MX Player Pro

JunkFood02 commented 2 years ago

Oh, I've tested it only with YouTube. I just tried the link you provide and reproduce the problem(with a Germany VPN🤕). However, I didn't see issues with the .ass subtitles embedded in the .mp4 video in my VLC player. But in case, we should better make --remux-video mkv enabled. Btw, this video uses the hlsnative(m3u8) stream so if I didn't specify the --concurrent-fragments N option(implemented in Seal already), the speed of downloading could be very slow.

Marco-9456 commented 2 years ago

Oh, I've tested it only with YouTube. I just tried the link you provide and reproduce the problem(with a Germany VPN🤕). However, I didn't see issues with the .ass subtitles embedded in the .mp4 video in my VLC player. But in case, we should better make --remux-video mkv enabled. Btw, this video uses the hlsnative(m3u8) stream so if I didn't specify the --concurrent-fragments N option(implemented in Seal already), the speed of downloading could be very slow.

That would be great brother 🙏 and sorry for the trouble

Marco-9456 commented 2 years ago

@JunkFood02 the new feature is not working 🥲🥲 I tried downloading from YouTube and Crunchyroll, it's not remuxing the video to mkv and not downloading any subtitles.

Marco-9456 commented 2 years ago

@JunkFood02 the new feature is not working 🥲🥲 I tried downloading from YouTube and Crunchyroll, it's not remuxing the video to mkv and not downloading any subtitles.

https://youtu.be/F5OJPUXJvHk

https://www.crunchyroll.com/de/jujutsu-kaisen/episode-1-ryomen-sukuna-797865

JunkFood02 commented 2 years ago

I'm just beginning to hate myself for introducing bugs named "features" 😢

Marco-9456 commented 2 years ago

I'm just beginning to hate myself for introducing bugs named "features" 😢

It can wait brother take your time 😃

JunkFood02 commented 2 years ago

Just one line of code for fix and now you can have another test 😢

Marco-9456 commented 2 years ago

Just one line of code for fix and now you can have another test 😢

On it

Marco-9456 commented 2 years ago

Just one line of code for fix and now you can have another test 😢

Yeah 🎉🎉

°Show Screenshots° ![Screenshot_20220809-024123_MiXplorer](https://user-images.githubusercontent.com/41828058/183538342-8e849de5-316f-47e8-9ea6-a3ae933b76c1.jpg)