JunkFood02 / Seal

🦭 Video/Audio Downloader for Android, based on yt-dlp, designed with Material You
GNU General Public License v3.0
10.59k stars 470 forks source link

Crunchyroll Hardsub #1211

Closed jeyemrs closed 2 weeks ago

jeyemrs commented 9 months ago

Checklist

Is your feature request related to a problem? Please describe.

I can't download hardsubs on Crunchyroll, especially when you're downloading a playlist or the whole series. I'll use the --extractor-args crunchyrollbeta:hardsub=en-US --match-filter "language=ja-JP" custom command to be able to use it. Also, to download your specific episodes or seasons, you'll need to do some match-filtering again and change the custom command every time you want to change them instead of just clicking them like on the GUI. Also, I can't use a proxy on the custom command because it will say, ERROR: To use an HTTPS proxy for this request, one of the following dependencies needs to be installed: requests. The hardsub is actually kind of possible, but only for 1 episode, you can't do it on a series. For you to do it, you'll manually find it through the list and find the filename with hardsub and the language of the sub.

Describe the solution you'd like

If the link is a Crunchyroll one, add an option for a hardsub one. It is already implemented in yt-dlp, which is like crunchyrollbeta:hardsub=en-US. Also, if possible, add an option for language. like if it is Japanese audio or an English dub.   This feature is especially useful since, if you use a playlist, you can choose which hardsub episodes or seasons you want to download on the GUI. Because as of the moment, you need to go and change the custom command manually every time you do it. It will also be useful for newbies like me.

This is merely a suggestion, if you don't want to implement it, then there's no problem, just say so. Thank you so much!

Video link

No response

Additional context

No response

Marco-9456 commented 9 months ago

https://github.com/JunkFood02/Seal/assets/41828058/e77609c3-ea07-4953-8ee0-7a8d41cb2c8a

JunkFood02 commented 9 months ago

This feature request looks a bit complicated. Anyway @Marco-9456 provides some contexts here

you'll need to do some match-filtering again and change the custom command every time you want to change them instead of just clicking them like on the GUI.

For what? Selecting episodes to download from a season, or selecting the format (in particular, hardsub video) to download from an episode?

jeyemrs commented 9 months ago

For what? Selecting episodes to download from a season, or selecting the format (in particular, hardsub video) to download from an episode?

Both. Like if I used a series link from Crunchyroll, I can use the playlist option and there'll be a GUI where I can choose whatever episodes I want. While I can see the Japanese and English Dub there, there's no way to download them with hardsubs.

Basically an option to download hardsubs for series link (using playlist option, where I can also choose what hardsubs episodes I want to download)

JunkFood02 commented 9 months ago

there's no way to download them with hardsubs

Actually, yes. We don't know which formats a video has before we extract the information of it from the website. And if we do so to the whole playlist, the process will be unbearably slow. Even if the complete information of a episode gets extracted, we can not distingiush the hardsub videos from ones which are not

using playlist option, where I can also choose what hardsubs episodes I want to download

The only solution at the moment might be to add additional custom commands for downloading in GUI mode, which seems like a overkill for this feature request.

Since --extractor-args crunchyrollbeta:hardsub=en-US --match-filter "language=ja-JP" works for your use case, did you try using --playlist-items to select the episode you want to download from a series?