search

JunkFood02 / Seal

🦭 Video/Audio Downloader for Android, based on yt-dlp, designed with Material You
GNU General Public License v3.0
11.02k stars 484 forks source link

My experience with Seal! One of the best! #26

Closed Fehertukor closed 2 years ago

Fehertukor commented 2 years ago

Hello @JunkFood02 !

First of all thank you for your time in this project! Beautiful, clean, user-friendly and more importantly it is suggestable to others! (Dark mode, custom colors, download personalisation ... )

  1. One suggestion to be more noob friendly, think about renaming: Extract audio to save as audio.

  2. Would it be possible to save audios in separate folder (I don't want to mix it with video files for podcast reasons)

  3. In the downloaded playlist. When I select to remove a file, add an option to always remember to delete files.

Thank you again!

JunkFood02 commented 2 years ago

I'm more than happy you like it! 😊 And thanks for your feature requests, I would consider including them in next updates.

JunkFood02 commented 2 years ago

Check v0.0.9-alpha03

Fehertukor commented 2 years ago

Thanks! That was really quick! :) I see everything works like charm!

Can we get a one extra step with separate downloads? By I mean getting chooseable folder for the audio files?(my podcast custom folder is in a separate location and I would love to save audio files there directly seal download suggest

JunkFood02 commented 2 years ago

Make sense. This would come with a UI update, so stay tuned for it. Btw I'm currently working on an RSS podcast app. 😄

Fehertukor commented 2 years ago

Please @ me if it is ready to test:)!

Fehertukor commented 2 years ago

Thank you! I have tested the v0.0.9-alpha04 and I could set the new audio location but when I tried to download it gave me this! audio download bug I tried other new locations and the old one download/seal got the same couldn't download the thumbnail bug. But as a video everything downloads as charm!

JunkFood02 commented 2 years ago

Could you provide a link to the video which causes error? I guess this is a storage permission issue, but it's weird that problems only occur when downloading audio. Let me know the version of Android OS you're using would help a lot.

Fehertukor commented 2 years ago

https://www.youtube.com/watch?v=1ZGIfsZ4YiE

I have to correct myself because in the original directory downloads/seal the audio downloads works. But in any other location get that bug.

JunkFood02 commented 2 years ago

Reproduced successfully on my side. Let me look into this. 🤔

JunkFood02 commented 2 years ago

After a bit of search I found this explained why this happens.

TL;DR

Android restricts that an app could only direct write to Documents/ and Documents/ directories, so we can only download into these directories (and their sub-directories). I think we just need to use the stupid Storage Access Framework provided by Android, copy files into destination directory and delete original ones, just like what dvd does. Anyway this would take some time for me to investigate how to copy a file properly

JunkFood02 commented 2 years ago

I'll close this and open a new one for SAF support