JunkFood02 / Seal

🦭 Video/Audio Downloader for Android, based on yt-dlp, designed with Material You
GNU General Public License v3.0
10.76k stars 476 forks source link

chapters marking support for youtube videos #342

Open venkat2305 opened 1 year ago

venkat2305 commented 1 year ago

Checklist

Is your feature request related to a problem? Please describe.

chapters download support for youtube videos

Describe the solution you'd like

chapters download support for youtube videos

Video link

https://www.youtube.com/watch?v=YiwPDyni0a8

Additional context

No response

JunkFood02 commented 1 year ago

Use custom command like --download-sections or --split-chapters

venkat2305 commented 1 year ago

will you add this feature directly to the app in the future please ? these commands are kind of confusing

JunkFood02 commented 1 year ago

will you add this feature directly to the app in the future please ? these commands are kind of confusing

These commands are complicated and hard to integrate into the GUI options too. If you can't figure out which option to use, turn to the yt-dlp community and they'll be happy to help

venkat2305 commented 1 year ago

thanks for answering. may I know, what features are on your To do?

venkat2305 commented 1 year ago

@JunkFood02 hey, this is implemented in this project. Both YouTube chapters and sponsoblock chapters were implemented. Can you please take a look and add it to seal. Thank you

JunkFood02 commented 1 year ago

I didn't get which feature about "chapters" you're requesting is, please describe it more clearly

venkat2305 commented 1 year ago

This video has chapters uploaded by the creator. We can see chapters in VLC media player. It looks like this for YouTube chapters Screenshot_2023-01-03-08-49-46-754_org.videolan.vlc.jpg

The chapters from sponsorblock look like this. Video link Screenshot_2023-01-03-08-52-19-347_org.videolan.vlc.jpg

For some videos , which have sponsor segments like in this video chapters look like this although seal has an option to remove these sponsor segments Screenshot_2023-01-03-08-58-12-138_org.videolan.vlc.jpg

It would be really helpful if you could add this

JunkFood02 commented 1 year ago

I see, this is "marking chapters" not "chapter downloading" and easy to implement

venkat2305 commented 1 year ago

Thought those two are the same.

venkat2305 commented 1 year ago

In 1.8.0-beta.2 , only chapters from YouTube are being marked. It would be great to have the option to mark sponsorblock chapters as well @JunkFood02

venkat2305 commented 1 year ago

Maybe there should be an option to mark sponsorblock chapters. Like a toggle. And by default YouTube chapters will be marked.

AbhiTheModder commented 1 year ago

@venkat2305 There's already an option for sponsorblock inside settings :)

venkat2305 commented 1 year ago

For chapters there isn't. There should be a separate toggle for chapters. Also, right now we can't see sponsorblock chapters in the video even though yt chapters are working

bibsp commented 1 year ago

@venkat2305 --embed-chapters is the command for that.

venkat2305 commented 1 year ago

It doesn't mark sponsorblock chapters.

bibsp commented 1 year ago

Always use --embed-chapters --sponsorblock-mark all for your purpose.

Do experiments with commands. You will find everything.

venkat2305 commented 1 year ago

I was asking for its GUI implementation. So, it would be easy to use