JunkFood02 / Seal

🦭 Video/Audio Downloader for Android, based on yt-dlp, designed with Material You
GNU General Public License v3.0
11.78k stars 510 forks source link

[Bug Report] buggy custom commands #476

Closed yant0 closed 1 year ago

yant0 commented 1 year ago

Describe the bug

After updating to 1.7.0. The custom commands became very buggy and few other issues i faced ever since updating.

To Reproduce

Tried with this soundcloud. Still have some issues even with the default custom command built in from the app.

Error reports & Screenshots

embed-thumbnail is ignored Screenshot_20230101-212702339

template -o "Audio/Commands/%(uploader)s/%(playlist_title|YT-DLP)s/%(playlist_autonumber)02d %(title)s.%(ext)s" -f "ba[ext=opus]/ba" --embed-thumbnail --parse-metadata "playlist_index:%(track_number)s" --parse-metadata "description:(?s)(?P.+)" --embed-metadata

Screenshot_20230101-212718_Bromite

Device info

Android 11 Custom rom. Seal 1.7.0 (F-droid) arm64-v8a

Additional context

The version of yt-dlp used is the same one that i used on the last update. 2022.11.11

yant0 commented 1 year ago

Sorry if its messy, im writing this on a phone and accidentally sent it too 🤦‍♂️

Marco-9456 commented 1 year ago

Sorry if its messy, I'm writing this on a phone and accidentally sent it too 🤦‍♂️

Try this:

-o "Audio/Commands/%(uploader)s/%(playlist_title|YT-DLP)s/%(playlist_autonumber)02d %(title)s.%(ext)s"
-f "ba[ext=opus]/ba"
--embed-thumbnail
--parse-metadata "playlist_index:%(track_number)s"
--parse-metadata ":(?P<description>)"
--embed-metadata

Try to write your commands in the template always this way for a better readability

Marco-9456 commented 1 year ago
*_* >the download notification for custom commands are just a looping bar. It used to work in previous versions. This happens to me sometimes >the download notification does not end after downloading. This is also happening to me. >ytdlp ignoring commands(??) Be specific >there are temp files. This is normal, if you want to delete them go to `Settings > Download Directory > Clear temporary files.` >**Note** This won't delete Custom Commands Temporary files. _____________________________________ >Tried with this soundcloud. Still have some issues even with the default custom command built in from the app. If you mean this one: `-f "bv*[ext=mp4]+ba[ext=m4a]/b[ext=mp4] / bv*+ba/b"` This is not for Downloading Music
JunkFood02 commented 1 year ago

Clear temporary files doesn't works for custom commands. But the problem you mentioned seems like a storage permission issue, have you changed your download directory? I've tried the link you provide but didn't reproduce the other issues except the first one

yant0 commented 1 year ago

Clear temporary files doesn't works for custom commands. But the problem you mentioned seems like a storage permission issue, have you changed your download directory? I've tried the link you provide but didn't reproduce the other issues except the first one

I suspect its on my end too (storage) i wanted to test out other links first but i accidentally click submit lol. I've tested it once again it works now. If youve known about the notification bug then i wouldnt mind the issue being closed. 👍

JunkFood02 commented 1 year ago

Thanks for your quick reply! I pushed a change that may fix the notification problem. You can install the CI apk once it finishes building to see if things work well

Marco-9456 commented 1 year ago

I pushed a change that may fix the notification problem. You can install the CI apk once it finishes building to see if things work well

Still looping

https://user-images.githubusercontent.com/41828058/210179185-da10178f-d379-4ae0-aab0-c8fecd145b87.mp4

Edit: After canceling this will be copied:

Error ``` ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ERROR: Postprocessing: Stream #0:1 -> #0:1 (copy) ```
JunkFood02 commented 1 year ago

The problem is complicated and hard to reproduce, but it seems to be related to the rate limit of notifications from the Android System. I'll take another look sooner