JunkFood02 / Seal

🦭 Video/Audio Downloader for Android, based on yt-dlp, designed with Material You
GNU General Public License v3.0
11.34k stars 496 forks source link

Custom output #65

Closed yant0 closed 2 years ago

yant0 commented 2 years ago

I used to configure dvd to seperate downloads to their own playlist name when downloading songs using -o %(playlist_title). It would be great if that or maybe the feature to add custom output when #34 is done to get custom directories without the default video/audio option greyed out. Thanks for the great app πŸ‘

JunkFood02 commented 2 years ago

For Android 10+, the custom directory works in any subdirectories(recursively) under Downloads/ and Documents/, so you can just simply create a new folder for a playlist download task.

yant0 commented 2 years ago

Good to know. But some weird artists use obsecure ascii to title their stuff (some times even name themself), you can find this just about anywhere on soundcloud. Requesting this for the sake of convenience.

Another reason is the artist could be in a country that have their own alphabet like japan / china

JunkFood02 commented 2 years ago

Make sense. The title output template is here, and a modification is not so difficult. Could you please provide a SoundCloud playlist link with weird characters for testing?

yant0 commented 2 years ago

For sure

edit : maybe also implement this for artist names too lmao /artist/album

JunkFood02 commented 2 years ago

I will only make this available to the output path (the -P option in yt-dlp) but not the filename due to some corner cases I don't want to handle. Stay tuned for the next release! 🀞

JunkFood02 commented 2 years ago

Please preview and test the two features you requested hereπŸ‘‡ (#95)

https://drive.google.com/file/d/1fwR2qVEv_JqrOOH20QDy7AVF-Q40yJbs/view?usp=sharing

yant0 commented 2 years ago

hm. Custom path & album title works flawlessly but im still getting 0 for track numbers. I usually use "playlist_index:%(track_number)s" for soundcloud.

Also for would u like me to make a seperate issue for custom made preset for websites? Im quite happy with just two of these feature.

JunkFood02 commented 2 years ago

i'm still getting 0 for track numbers. I usually use "playlist_index:%(track_number)s" for soundcloud.

I would suggest not to hard code the track numbers into native download option. In soundcloud, we can download whole >discog and in my preference i would have the track numbers to be 0 since there could be new releases.

Are these two you mentioned just contradictory to each other?

yant0 commented 2 years ago

It does. But, i use 0 as track number only for singles and put them in all in one folder, and i need that track number to be 0 to not mess the sorting. I mention discography and not playlist/albums since you can download an artist's whole uploads by soundcloud.com/artist/tracks. i believe, since we are downloading a user, it puts their name as an album (and if we turn on the custom directories we got their name as a folder) so theoretically i just need to tag the songs on that album and move it elsewhere.

I put artists singles into one folder. So when i batch download a artist i would like to put their singles there in the singles folder without the track numbers being mixed up.

Thats just my use case. Im fine with it being hard coded but i need to retag each one of them and put it in the folder.

Edit : actually nvm i can batch retag songs. So ignore what i just said

What i meant by not being hardcoded is there needs to be an option to turn it on, instead of being inside the native downloader's code that normal users cant access

And as i said last on that quote. Im fine being it hardcoded since i realized i can batch retag them now.

I apologize for not clarifying things properly.

JunkFood02 commented 2 years ago

I see. So you use the playlist download to download all tracks from users/albums. And yt-dlp would extract different information from these two "playlists", causing all the problems and complexity. I think this cannot be avoided and should be solved manually. In addition, I want to keep the app simple and straightforward to use, so I'll not provide options for the custom metadata controls.

yant0 commented 2 years ago

Whats ur thoughts on premade commands for specific websites mentioned in #95? This way i can set up commands when i want to download singles and albums separately.

JunkFood02 commented 2 years ago

Whats ur thoughts on premade commands for specific websites mentioned in #95? This way i can set up commands when i want to download singles and albums separately.

Do you mean having multiple templates stored in the app for "custom command" mode?

yant0 commented 2 years ago

Yes

JunkFood02 commented 2 years ago

Yes

Make sense. Will be added in v1.0.1 🀞