search

JunoLab / Atom.jl

Julia Client for Atom
MIT License
71 stars 30 forks source link

fix function display on v1.6 #339

Closed aviatesk closed 4 years ago

aviatesk commented 4 years ago

I found string(typeof(f).name) returns "typename(typeof(f))", which causes function display a bit weird (e.g. sin() on v1.6 (at least current master)

I believe using repr and string would make the logic mach simpler and robust in the future, so this PR.

I also improved a logic in a completion a bit

codecov[bot] commented 4 years ago

Codecov Report

Merging #339 into master will decrease coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   55.63%   55.54%   -0.10%     
==========================================
  Files          43       43              
  Lines        2644     2634      -10     
==========================================
- Hits         1471     1463       -8     
+ Misses       1173     1171       -2
Flag Coverage Δ
#unittests 55.54% <100.00%> (-0.10%) :arrow_down:
Impacted Files Coverage Δ
src/completions.jl 78.77% <100.00%> (+0.39%) :arrow_up:
src/display/base.jl 37.09% <100.00%> (-3.82%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f43a59...e93747f. Read the comment docs.